Changeset 0dedfbe in OpenWorkouts-current for ow

Timestamp:

Apr 22, 2019, 10:47:55 PM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current

Children:

a6fa857

Parents:

42baca4

Message:

(#39) Duplicated workouts, fixed broken tests, added more tests coverage

Location:

ow/tests

Files:

• models/test_root.py (modified) (2 diffs)
• models/test_workout.py (modified) (1 diff)
• views/test_workout.py (modified) (4 diffs)

ow/tests/models/test_root.py

@@ -2 +2 @@
 from unittest.mock import Mock
 from datetime import datetime, timedelta, timezone
+from decimal import Decimal
 
 import pytest
@@ -175 +176 @@
         john.add_workout(workout)
         assert root.sports_json == json.dumps(["cycling", "running"])
+
+    def test_get_workout_by_hash(self, root, john):
+        # non existant hash
+        found = root.get_workout_by_hash('non-existant-hash')
+        assert found is None
+        # existing workout
+        workout = root[str(john.uid)]['1']
+        found = root.get_workout_by_hash(workout.hashed)
+        assert found == workout
+        # a workout that was not added to the system
+        workout = Workout(
+            start_time=datetime.now(timezone.utc),
+            duration=timedelta(seconds=3600),
+            distance=Decimal(30)
+        )
+        found = root.get_workout_by_hash(workout.hashed)
+        assert found is None

ow/tests/models/test_workout.py

@@ -143 +143 @@
         workout.distance = 44.44444444
         assert workout.rounded_distance == 44.44
+
+    def test_hashed(self, root):
+        # first test a workout that is attached to a user
+        workout = root['john']['1']
+        assert workout.hashed == (
+            str(workout.owner.uid) +
+            workout.start.strftime('%Y%m%d%H%M%S') +
+            str(workout.duration.seconds) +
+            str(workout.distance)
+        )
+        # now a workout that is not (no owner info)
+        workout = Workout(
+            start_time=datetime.now(timezone.utc),
+            duration=timedelta(seconds=3600),
+            distance=Decimal(30)
+        )
+        assert workout.hashed == (
+            workout.start.strftime('%Y%m%d%H%M%S') +
+            str(workout.duration.seconds) +
+            str(workout.distance)
+        )
+        # now an empty workout...
+        workout = Workout()
+        with pytest.raises(AttributeError):
+            assert workout.hashed == (
+                workout.start.strftime('%Y%m%d%H%M%S') +
+                str(workout.duration.seconds) +
+                str(workout.distance)
+            )
 
     def test_trimmed_notes(self):

ow/tests/views/test_workout.py

@@ -182 +182 @@
         assert len(response['form'].form.errors) == 0
         assert isinstance(response['form'].form.schema, UploadedWorkoutSchema)
+        assert response['duplicate'] is None
 
     def test_add_workout_post_invalid(self, dummy_request):
@@ -196 +197 @@
         # Only one required field in this case, the tracking file
         assert len(response['form'].form.errors) == 1
+        assert response['duplicate'] is None
 
     def test_add_workout_post_invalid_bytes(self, dummy_request):
@@ -214 +216 @@
         # Only one required field in this case, the tracking file
         assert len(response['form'].form.errors) == 1
+        assert response['duplicate'] is None
 
     @pytest.mark.parametrize('filename', gpx_filenames)
@@ -234 +237 @@
         assert response.location.endswith('/2/')
         assert len(request.root['john'].workouts()) == 2
+        self.close_uploaded_file(uploaded_file)
+
+    def test_add_workout_post_duplicate(self, dummy_request):
+        """
+        POST request, first add a workout uploading one of the sample
+        tracking files, then try to upload it again.
+        """
+        # first, upload the workout
+        filename = self.gpx_filenames[0]
+        request = dummy_request
+        uploaded_file = self.open_uploaded_file(filename)
+        filestorage = self.create_filestorage(uploaded_file)
+        user = request.root['john']
+        request.method = 'POST'
+        request.POST = MultiDict({
+            'tracking_file': filestorage,
+            'submit': True,
+            })
+        assert len(request.root['john'].workouts()) == 1
+        response = workout_views.add_workout(user, request)
+        assert isinstance(response, HTTPFound)
+        assert response.location.endswith('/2/')
+        assert len(request.root['john'].workouts()) == 2
+        self.close_uploaded_file(uploaded_file)
+        # now, try to upload it again
+        uploaded_file = self.open_uploaded_file(filename)
+        filestorage = self.create_filestorage(uploaded_file)
+        user = request.root['john']
+        request.method = 'POST'
+        request.POST = MultiDict({
+            'tracking_file': filestorage,
+            'submit': True,
+            })
+        response = workout_views.add_workout(user, request)
+        assert response['duplicate'] == request.root['john']['2']
+        assert len(request.root['john'].workouts()) == 2
+        self.close_uploaded_file(uploaded_file)
+        # finally, override the duplicate prevention code and save it
+        uploaded_file = self.open_uploaded_file(filename)
+        filestorage = self.create_filestorage(uploaded_file)
+        user = request.root['john']
+        request.method = 'POST'
+        request.POST = MultiDict({
+            'tracking_file': filestorage,
+            'allow_duplicates': 'on',
+            'submit': True,
+            })
+        response = workout_views.add_workout(user, request)
+        assert isinstance(response, HTTPFound)
+        assert response.location.endswith('/3/')
+        assert len(request.root['john'].workouts()) == 3
         self.close_uploaded_file(uploaded_file)