Changeset 6560b8f in OpenWorkouts-current

Timestamp:

Dec 16, 2018, 1:32:35 AM (5 years ago)

Author:

borja <borja@…>

Branches:

current, feature/docs, master

Children:

f24ad73

Parents:

1d92bf2

Message:

Fixed a bug in the edit_profile view that was breaking the edit profile

operation when a profile image was not provided.

This comes from the latest Formencode in python 3.x, this patch is a quick
and dirty hack while upstream does not fix it.

Location:

ow

Files:

• schemas/user.py (modified) (1 diff)
• views/user.py (modified) (1 diff)

ow/schemas/user.py

@@ -71 +71 @@
     weight = validators.Number()
     gender = validators.OneOf(('male', 'female'), not_empty=True)
-    picture = FieldStorageBlob(whitelist=['jpg', 'jpeg', 'png', 'gif'])
+    picture = FieldStorageBlob(if_emtpy=None, if_missing=None,
+                               whitelist=['jpg', 'jpeg', 'png', 'gif'])
 
 

ow/views/user.py

@@ -144 +144 @@
     renderer='ow:templates/edit_profile.pt')
 def edit_profile(context, request):
+    # if not given a file there is an empty byte in POST, which breaks
+    # our blob storage validator.
+    # dirty fix until formencode fixes its api.is_empty method
+    if isinstance(request.POST.get('picture', None), bytes):
+        request.POST['picture'] = ''
+
     form = Form(request, schema=UserProfileSchema(), obj=context)
+
     if 'submit' in request.POST and form.validate():
         # No picture? do not override it