Changeset 74b9c4d in OpenWorkouts-current for ow

Timestamp:

Dec 18, 2018, 10:24:34 AM (5 years ago)

Author:

borja <borja@…>

Branches:

current, feature/docs, master

Children:

d507f75

Parents:

4554843

Message:

Fixed FormEncode? bug with empty file uploads in the views that handle posting

tracking files for new/existing workouts.

File:

• ow/views/workout.py (modified) (2 diffs)

ow/views/workout.py

@@ -64 +64 @@
     Add a workout uploading a tracking file
     """
+    # if not given a file there is an empty byte in POST, which breaks
+    # our blob storage validator.
+    # dirty fix until formencode fixes its api.is_empty method
+    if isinstance(request.POST.get('tracking_file', None), bytes):
+        request.POST['tracking_file'] = ''
+
     form = Form(request, schema=UploadedWorkoutSchema())
 
@@ -129 +135 @@
     renderer='ow:templates/update_workout_from_file.pt')
 def update_workout_from_file(context, request):
+    # if not given a file there is an empty byte in POST, which breaks
+    # our blob storage validator.
+    # dirty fix until formencode fixes its api.is_empty method
+    if isinstance(request.POST.get('tracking_file', None), bytes):
+        request.POST['tracking_file'] = ''
+
     form = Form(request, schema=UpdateWorkoutSchema())
     if 'submit' in request.POST and form.validate():