Changeset f0e64eb in OpenWorkouts-current for ow/tests

Timestamp:

Feb 15, 2019, 11:00:35 AM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current, feature/docs, master

Children:

0fa21cd

Parents:

eb20dc8

Message:

(#51) Fixed profile images were too big:

• Added new dependency (Pillow)

• Modified the user profile picture view. Now it accepts a GET parameter (size) telling the size of the image we want. Only one value is needed, the code will scale the image appropiately.

• Modified the dashboard, profile and edit_profile templates to ask for a smaller version (200px) of the user profile picture.

IMPORTANT: Ensure you install Pillow in any existing environments after pulling:

pip install Pillow

File:

• ow/tests/views/test_user.py (modified) (3 diffs)

ow/tests/views/test_user.py

@@ -5 +5 @@
 from shutil import copyfileobj
 from unittest.mock import Mock, patch
+from io import BytesIO
 
 import pytest
@@ -15 +16 @@
 
 from webob.multidict import MultiDict
+
+from PIL import Image
 
 from ow.models.root import OpenWorkouts
@@ -417 +420 @@
         assert response.status_int == 200
         assert response.content_type == 'image'
+        # as we did not pass a specific size as a get parameter, the size is
+        # the same as the original image
+        original_image = Image.open(image_path)
+        returned_image = Image.open(BytesIO(response.body))
+        assert original_image.size == returned_image.size
+
+        # now, ask for a smaller image
+        request.GET['size'] = original_image.size[0] - 20
+        response = user_views.profile_picture(user, request)
+        assert isinstance(response, Response)
+        assert response.status_int == 200
+        assert response.content_type == 'image'
+        # now the size of the original image is bigger
+        returned_image = Image.open(BytesIO(response.body))
+        assert original_image.size > returned_image.size
+
+        # now, ask for a size that is bigger than the original image,
+        # image will be the same size, as we do not "grow" its size
+        request.GET['size'] = original_image.size[0] + 1000
+        response = user_views.profile_picture(user, request)
+        assert isinstance(response, Response)
+        assert response.status_int == 200
+        assert response.content_type == 'image'
+        # now the size of the original image is bigger
+        returned_image = Image.open(BytesIO(response.body))
+        assert original_image.size == returned_image.size
+
 
     def test_edit_profile_get(self, dummy_request, john):