Changeset 1829fbf in OpenWorkouts-current for ow/mail.py

Timestamp:

Feb 20, 2019, 9:31:22 PM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current, feature/docs, master

Children:

38171c6

Parents:

42d775c

Message:

(#61) Several fixes for the multipart/alternative (text+html) version of the verify
your account email:

• Use premailer [1] to embed all styles into the body of the html part of the email (ensuring the styles are rendered correctly in most email clients)

• Fixed some styles (RGB colors, transparencies, etc don't work in mail clients)

• Ensure the different bodies (text and html) have the proper content type and charset set.

[1] ​https://pypi.org/project/premailer

File:

• ow/mail.py (modified) (2 diffs)

ow/mail.py

@@ -2 +2 @@
 
 from pyramid_mailer import get_mailer
-from pyramid_mailer.message import Message
+from pyramid_mailer.message import Message, Attachment
 from pyramid.renderers import render
 from pyramid.i18n import TranslationStringFactory
+
+import premailer
 
 _ = TranslationStringFactory('OpenWorkouts')
@@ -45 +47 @@
     mailer = get_mailer(request)
     txt_body = render(txt_template, context, request)
-    html_body = render(html_template, context, request)
+    html_body = premailer.transform(render(html_template, context, request))
     message = Message(
         subject=subject,
         recipients=[user.email],
-        body=txt_body,
-        html=html_body
+        body=Attachment(data=txt_body,
+                        content_type="text/plain; charset=utf-8",
+                        transfer_encoding="quoted-printable"),
+        html=Attachment(data=html_body,
+                        content_type="text/html; charset=utf-8",
+                        transfer_encoding="quoted-printable")
     )
     message = idna_encode_recipients(message)