Changeset 42baca4 in OpenWorkouts-current for ow/views/workout.py

Timestamp:

Apr 22, 2019, 6:14:53 PM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current

Children:

0dedfbe

Parents:

e52a502

Message:

(#39) Do not allow duplicated workouts by default when uploading track files.
We still allow users to add duplicates if they want, by checking a checkbox
we show in the upload workout form when we find a possible duplicate.

File:

• ow/views/workout.py (modified) (2 diffs)

ow/views/workout.py

@@ -89 +89 @@
     form = Form(request, schema=UploadedWorkoutSchema())
 
+    duplicate = None
+    allow_duplicates = request.POST.get('allow_duplicates') == 'on'
+
     if 'submit' in request.POST and form.validate():
         # Grab some information from the tracking file
@@ -98 +101 @@
         # Add basic info gathered from the file
         workout.load_from_file()
-        # Add the workout
-        context.add_workout(workout)
-        return HTTPFound(location=request.resource_url(workout))
+        # Ensure this workout is not a duplicate of an existing workout.
+        #
+        # hashed is not "complete" for a workout that has not been added
+        # yet, as it does not have the owner set, so we have to "build it"
+        hashed = str(context.uid) + workout.hashed
+        duplicate = request.root.get_workout_by_hash(hashed)
+
+        if duplicate and not allow_duplicates:
+            form.errors['tracking_file'] = _(
+                'This workout looks like a duplicate of another workout, '
+                'please enable workout duplicates below to save it'
+            )
+        else:
+            # Add the workout
+            context.add_workout(workout)
+            return HTTPFound(location=request.resource_url(workout))
 
     return {
-        'form': FormRenderer(form)
+        'form': FormRenderer(form),
+        'duplicate': duplicate
     }