Changeset b8ef4ab in OpenWorkouts-current for ow/tests/test_mail.py

Timestamp:

Feb 19, 2019, 6:58:39 PM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current, feature/docs, master

Children:

42d775c

Parents:

07f5190

Message:

(#61) Better templates for "verify your account" emails:

• Send a multipart text/html email (instead text only)
• Added some styling to the html version of the email, based on our current login page styles.

Important: as the html version contains html code generated using
request.resource_url() and request.static_url(), when running in
development mode under ​http://localhost, the links to images
and css files in the rendered email point to localhost, so they
won't work outside the machine running openworkouts.

File:

• ow/tests/test_mail.py (modified) (2 diffs)

ow/tests/test_mail.py

@@ -41 +41 @@
         message.recipients = ['user@example.net']
         m.return_value = message
-        body = Mock()
-        r.return_value = body
+
+        txt_body = Mock()
+        html_body = Mock()
+        r.side_effect = [txt_body, html_body]
+
         request = DummyRequest()
         request.root = root
@@ -49 +52 @@
         verify_link = request.resource_url(
             user, 'verify', user.verification_token)
-        r.assert_called_once_with(
-            'ow:templates/mail_verify_account.pt',
-            {'user': user, 'verify_link': verify_link},
-            request
-        )
+
+        # two render calls
+        assert r.call_count == 2
+
+        # first call renders the text version of the email
+        assert r.call_args_list[0][0][0] == (
+            'ow:templates/mail_verify_account_txt.pt')
+        assert r.call_args_list[0][0][1] == (
+            {'user': user, 'verify_link': verify_link})
+        assert r.call_args_list[0][0][2] == request
+
+        # second call renders the html version of the email
+        assert r.call_args_list[1][0][0] == (
+            'ow:templates/mail_verify_account_html.pt')
+        assert r.call_args_list[1][0][1] == (
+            {'user': user, 'verify_link': verify_link})
+        assert r.call_args_list[1][0][2] == request
+
         m.assert_called_once
         m.call_args_list[0][1]['recipients'] == user.email
-        m.call_args_list[0][1]['body'] == body
+        m.call_args_list[0][1]['body'] == txt_body
+        m.call_args_list[0][1]['html'] == html_body
         mailer.send_to_queue.assert_called_once_with(message)