Changeset 1d92bf2 in OpenWorkouts-current for ow/tests/views/test_root.py

Timestamp:

Dec 16, 2018, 1:07:04 AM (5 years ago)

Author:

borja <borja@…>

Branches:

current, feature/docs, master

Children:

6560b8f

Parents:

929097a

Message:

(#37) Allow login using email address instead of username:

• Use user uids as keys in the root folder for referencing user objects (instead of username)

• Use uids for referencing users all over the place (auth, permissions, traversal urls, etc)

• Replaced the username concept with nickname. This nickname will be used as a shortcut to access "public profile" pages for users

• Reworked lots of basic methods in the OpenWorkouts root object (s/username/nickname, marked as properties some methods like users, emails, etc)

• Added new add_user() and delete_user() helpers to the OpenWorkouts root object

• Modified views to match the new OpenWorkouts root helpers

• Fixed bug in the dashboard redirect view, causing an endless loop if an authenticated user does not exist anymore when loading a page.

• Lots of tests fixes, adaptations and catch up.

File:

• ow/tests/views/test_root.py (modified) (5 diffs)

ow/tests/views/test_root.py

@@ -20 +20 @@
 
     @pytest.fixture
-    def root(self):
+    def john(self):
+        user = User(firstname='John', lastname='Doe',
+                    email='john.doe@example.net')
+        user.password = 's3cr3t'
+        return user
+
+    @pytest.fixture
+    def root(self, john):
         root = OpenWorkouts()
-        root['john'] = User(firstname='John', lastname='Doe',
-                            email='john.doe@example.net')
-        root['john'].password = 's3cr3t'
+        root.add_user(john)
         workout = Workout(
             start=datetime(2015, 6, 28, 12, 55, tzinfo=timezone.utc),
@@ -30 +35 @@
             distance=30, sport='cycling'
         )
-        root['john'].add_workout(workout)
+        john.add_workout(workout)
         return root
 
@@ -50 +55 @@
         return request
 
-    def test_user_list(self, get_request):
+    def test_user_list(self, get_request, john):
         request = get_request
         response = user_list(request.root, request)
-        assert list(response['users']) == [request.root['john']]
+        assert list(response['users']) == [john]
 
     def test_add_user_get(self, get_request):
@@ -66 +71 @@
         response = add_user(request.root, request)
         assert 'form' in response
-        # All required fields (4) are marked in the form errors
+        # All required fields (3) are marked in the form errors
         # You can see which fields are required in the schema
         # ow.schemas.user.UserAddSchema
-        assert len(response['form'].form.errors) == 4
+        errors = response['form'].form.errors
+        assert len(errors) == 3
+        assert 'email' in errors
+        assert 'firstname' in errors
+        assert 'lastname' in errors
 
     def test_add_user_post_valid(self, post_request):
         request = post_request
-        request.POST['uid'] = 'addeduser'
+        request.POST['nickname'] = 'addeduser'
         request.POST['email'] = 'addeduser@example.net'
         request.POST['firstname'] = 'added'
@@ -80 +89 @@
         assert isinstance(response, HTTPFound)
         assert response.location.endswith('/userlist')
-        assert len(request.root.all_usernames()) == 2
-        assert 'addeduser' in request.root.all_usernames()
+        # 1 nick name, as the default user has no nickname
+        assert len(request.root.all_nicknames) == 1
+        assert 'addeduser' in request.root.all_nicknames