Changeset d6f8304 in OpenWorkouts-current for ow/tests/test_utilities.py

Timestamp:

Feb 11, 2019, 6:55:55 PM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current, feature/docs, master

Children:

02aee97

Parents:

93bbb89

Message:

(#52) - screenshots of the workouts maps were corrupted randomly.

Replaced our screenshot_map shell script that was calling chrome headless
directly with some python code running splinter + selenium webdriver.

Using chromedriver in such environment we can first visit the map site
for the given workout, then wait a bit for it to completely load, then
take the screenshot.

I've also removed all traces of screenshot_map from the code.

File:

• ow/tests/test_utilities.py (modified) (6 diffs)

ow/tests/test_utilities.py

@@ -1 +1 @@
 import os
 from datetime import timedelta, datetime
-from unittest.mock import patch
+from unittest.mock import patch, Mock
 from pyexpat import ExpatError
 from xml.dom.minidom import Element
 
 import pytest
+from pyramid.testing import DummyRequest
 
 from ow.models.root import OpenWorkouts
@@ -83 +84 @@
         assert kmph_to_mps(30) == 30 * 0.277778
 
+    @patch('ow.utilities.shutil')
     @patch('ow.utilities.os')
-    @patch('ow.utilities.subprocess')
-    def test_save_map_screenshot_no_gpx(self, subprocess, os, root, john):
-        saved = save_map_screenshot(john['1'])
+    @patch('ow.utilities.Browser')
+    def test_save_map_screenshot_no_gpx(
+            self, Browser, os, shutil, root, john):
+        request = DummyRequest()
+        saved = save_map_screenshot(john['1'], request)
         assert not saved
+        assert not Browser.called
         assert not os.path.abspath.called
         assert not os.path.dirname.called
@@ -93 +98 @@
         assert not os.path.exists.called
         assert not os.makedirs.called
-        assert not subprocess.run.called
+        assert not shutil.move.called
         # even having a fit tracking file, nothing is done
         john['1'].tracking_file = 'faked fit file'
         john['1'].tracking_filetype = 'fit'
-        saved = save_map_screenshot(john['1'])
+        saved = save_map_screenshot(john['1'], request)
         assert not saved
+        assert not Browser.called
         assert not os.path.abspath.called
         assert not os.path.dirname.called
@@ -104 +110 @@
         assert not os.path.exists.called
         assert not os.makedirs.called
-        assert not subprocess.run.called
-
+        assert not shutil.move.called
+
+    @patch('ow.utilities.shutil')
     @patch('ow.utilities.os')
-    @patch('ow.utilities.subprocess')
-    def test_save_map_screenshot_with_gpx(self, subprocess, os, root, john):
+    @patch('ow.utilities.Browser')
+    def test_save_map_screenshot_with_gpx(
+            self, Browser, os, shutil, root, john):
+        request = DummyRequest()
+        browser = Mock()
+        Browser.return_value = browser
         os.path.abspath.return_value = 'current_dir'
         os.path.join.side_effect = join
@@ -116 +127 @@
         os.path.exists.return_value = False
 
+        map_url = request.resource_url(john['1'], 'map')
+
         john['1'].tracking_file = 'faked gpx content'
         john['1'].tracking_filetype = 'gpx'
-        saved = save_map_screenshot(john['1'])
+        saved = save_map_screenshot(john['1'], request)
         assert saved
+        Browser.assert_called_once_with('chrome', headless=True)
+        browser.driver.set_window_size.assert_called_once_with(1300, 436)
+        browser.visit.assert_called_once_with(map_url)
+        browser.screenshot.assert_called_once
         os.path.abspath.assert_called_once
         assert os.path.dirname.called
-        assert os.path.join.call_count == 3
+        assert os.path.join.call_count == 2
         assert os.path.exists.called
         assert os.makedirs.called
-        subprocess.run.assert_called_once
-
+        os.shutil.move.assert_called_once
+
+    @patch('ow.utilities.shutil')
     @patch('ow.utilities.os')
-    @patch('ow.utilities.subprocess')
+    @patch('ow.utilities.Browser')
     def test_save_map_screenshot_with_gpx_makedirs(
-            self, subprocess, os, root, john):
+            self, Browser, os, shutil, root, john):
+        request = DummyRequest()
+        browser = Mock()
+        Browser.return_value = browser
         os.path.abspath.return_value = 'current_dir'
         os.path.join.side_effect = join
@@ -136 +157 @@
         os.path.exists.return_value = True
 
+        map_url = request.resource_url(john['1'], 'map')
+
         john['1'].tracking_file = 'faked gpx content'
         john['1'].tracking_filetype = 'gpx'
-        saved = save_map_screenshot(john['1'])
+        saved = save_map_screenshot(john['1'], request)
         assert saved
+        Browser.assert_called_once_with('chrome', headless=True)
+        browser.driver.set_window_size.assert_called_once_with(1300, 436)
+        browser.visit.assert_called_once_with(map_url)
+        browser.screenshot.assert_called_once
         os.path.abspath.assert_called_once
         assert os.path.dirname.called
-        assert os.path.join.call_count == 3
+        assert os.path.join.call_count == 2
         assert os.path.exists.called
         assert not os.makedirs.called
-        subprocess.run.assert_called_once
+        os.shutil.move.assert_called_once
 
     def test_timedelta_to_hms(self):