Changeset d6f8304 in OpenWorkouts-current for ow/utilities.py

Timestamp:

Feb 11, 2019, 6:55:55 PM (5 years ago)

Author:

Borja Lopez <borja@…>

Branches:

current, feature/docs, master

Children:

02aee97

Parents:

93bbb89

Message:

(#52) - screenshots of the workouts maps were corrupted randomly.

Replaced our screenshot_map shell script that was calling chrome headless
directly with some python code running splinter + selenium webdriver.

Using chromedriver in such environment we can first visit the map site
for the given workout, then wait a bit for it to completely load, then
take the screenshot.

I've also removed all traces of screenshot_map from the code.

File:

• ow/utilities.py (modified) (4 diffs)

ow/utilities.py

@@ -3 +3 @@
 import logging
 import calendar
-import subprocess
+import shutil
+import time
 from datetime import datetime, timedelta
 from decimal import Decimal
@@ -11 +12 @@
 from xml.dom import minidom
 from ZODB.blob import Blob
+from splinter import Browser
+
 
 log = logging.getLogger(__name__)
@@ -192 +195 @@
 
 
-def save_map_screenshot(workout):
+def save_map_screenshot(workout, request):
+
     if workout.has_gpx:
+
+        map_url = request.resource_url(workout, 'map')
+
+        browser = Browser('chrome', headless=True)
+        browser.driver.set_window_size(1300, 436)
+
+        browser.visit(map_url)
+        # we need to wait a moment before taking the screenshot, to ensure
+        # all tiles are loaded in the map.
+        time.sleep(5)
+
+        # splinter saves the screenshot with a random name (even if we do
+        # provide a name) so we get the path to that file and later on we
+        # move it to the proper place
+        splinter_screenshot_path = browser.screenshot()
+
         current_path = os.path.abspath(os.path.dirname(__file__))
-        tool_path = os.path.join(current_path, '../bin/screenshot_map')
-
         screenshots_path = os.path.join(
             current_path, 'static/maps', str(workout.owner.uid))
@@ -206 +224 @@
         screenshot_path += '.png'
 
-        subprocess.run(
-            [tool_path, str(workout.owner.uid), str(workout.workout_id),
-             screenshot_path], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+        shutil.move(splinter_screenshot_path, screenshot_path)
 
         return True